boost: support for cross-compiling to mips64el · Pull Request #161162 · NixOS/nixpkgs

ghost · 2022-02-21T05:23:11Z

This patch adds support for cross-compiling boost to a mips64el hostPlatform.

Motivation for this change

This is needed in order to bootstrap nixpkgs on a mips64el hostPlatform -- if the initial mips64el nix binary is to be built using nixpkgs, it needs to be cross-compiled from some other platform.

Things done

Built on platform(s)
- x86_64-linux
- mips64el-linux (cross from x86_64-linux)
- aarch64-linux
Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
Fits CONTRIBUTING.md.

ghost · 2022-02-24T06:00:11Z

Previous push just rebases updates to #161159.

ghost · 2022-03-03T05:15:55Z

Latest push rebases against #161159 and squashes this PR into a single commit; no other changes.

pkgs/development/libraries/boost/generic.nix

lib/systems/parse.nix

ghost · 2022-03-04T19:22:15Z

Latest push squashes to a single commit and rebases on #161159; no other changes.

pkgs/development/libraries/boost/generic.nix

SuperSandro2000

after that I think we can merge this. Going to build it locally to see if something regresses.

pkgs/development/libraries/boost/generic.nix

SuperSandro2000 · 2022-04-12T13:22:08Z

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).

Result of nixpkgs-review pr 161162 run on x86_64-linux 1

1 package marked as broken and skipped:

rapcad

6 packages failed to build and already failed to build on hydra master:

appleseed: log was empty
masari: plain log | pretty log
osl: plain log | pretty log
python310Packages.appleseed: log was empty
python310Packages.boost169: plain log | pretty log
sourcetrail: log was empty

19 packages failed to build and are new build failures:

amarok: log was empty
(amarok-kf5): log was empty
(python39Packages.appleseed): log was empty
boost155: plain log | pretty log
boost159: plain log | pretty log
(boost15x): log was empty
boost160: plain log | pretty log
cqrlog: log was empty
globulation2: log was empty
mongodb: log was empty
(mongodb-3_4): log was empty
mongodb-3_6: log was empty
mongodb-4_0: plain log | pretty log
mongodb-4_2: plain log | pretty log
mysql57: log was empty
percona-xtrabackup_2_4: log was empty
qpid-cpp: log was empty
spring: log was empty
springLobby: log was empty

38 packages built:

SkypeExport
arc_unpacker
bitcoin-abc
bitcoin-classic
bitcoin-gold
bitcoind-abc
bitcoind-classic
bitcoind-gold
boost165
boost166
boost168
boost169 (boost16x)
clfft
cpp-netlib
dogecoin
dogecoind
ethminer (ethminer-cuda)
ethminer-free
foundationdb (foundationdb61)
freecad
freeorion
ispike
mirtk
mozart2
performous
pokerth
pokerth-server
python310Packages.foundationdb61
python39Packages.boost169
python39Packages.foundationdb61
starspace
sumokoin
swift-im
twister
vertcoin
vertcoind
xtreemfs
yafaray-core

ghost · 2022-04-12T21:11:07Z

amarok: log was empty

(amarok-kf5): log was empty

(python39Packages.appleseed): log was empty

boost155: plain log | pretty log

boost159: plain log | pretty log

(boost15x): log was empty

boost160: plain log | pretty log

cqrlog: log was empty

globulation2: log was empty

mongodb: log was empty

(mongodb-3_4): log was empty

mongodb-3_6: log was empty

mongodb-4_0: plain log | pretty log

mongodb-4_2: plain log | pretty log

mysql57: log was empty

percona-xtrabackup_2_4: log was empty

qpid-cpp: log was empty

spring: log was empty

springLobby: log was empty

Thanks, I am investigating these.

ghost · 2022-04-12T21:59:40Z

Resolved merge conflict with master.

ghost · 2022-04-12T22:21:11Z

Okay, latest push should fix the breakage. The patch to backport mips64n64 support doesn't apply cleanly to anything before 1.65, but very few packages require a version of boost older than that.

Co-authored-by: Sandro <sandro.jaeckel@gmail.com>

ghost · 2022-04-12T22:42:41Z

I'm running nixpkgs-review pr 161162 myself, it'll take a while though.

ghost · 2022-04-13T08:35:09Z

I'm running nixpkgs-review pr 161162 myself, it'll take a while though.

8 packages failed to build:
appleseed masari mongodb-4_0 mongodb-4_2 osl python310Packages.appleseed python310Packages.boost169 sourcetrail

Of these, only mongodb-4_0 and mongodb-4_2 were not on the "already failing before PR" list. I tried building those at the previous commit and they failed there as well, with:

src/mongo/stdx/thread.h: At global scope:
src/mongo/stdx/thread.h:109:56: error: call to non-'constexpr' function 'long int sysconf(int)'
  109 |         std::max(kMongoMinSignalStackSize, std::size_t{MINSIGSTKSZ});
      |                                                        ^~~~~~~~~~~

So, I'm going to say that at this point this PR is not causing any additional breakage. @SuperSandro2000, could you run your bot-tool again? I think this is ready to merge now.

SuperSandro2000 · 2022-04-13T10:34:35Z

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).

Result of nixpkgs-review pr 161162 run on x86_64-linux 1

6 packages failed to build and already failed to build on hydra master:

appleseed: log was empty
masari: plain log | pretty log
osl: plain log | pretty log
python310Packages.appleseed: log was empty
python310Packages.boost169: plain log | pretty log
sourcetrail: log was empty

3 packages failed to build and are new build failures:

(python39Packages.appleseed): log was empty
mongodb-4_0: plain log | pretty log
mongodb-4_2: plain log | pretty log

38 packages built:

SkypeExport
arc_unpacker
bitcoin-abc
bitcoin-classic
bitcoin-gold
bitcoind-abc
bitcoind-classic
bitcoind-gold
boost165
boost166
boost168
boost169 (boost16x)
clfft
cpp-netlib
dogecoin
dogecoind
ethminer (ethminer-cuda)
ethminer-free
foundationdb (foundationdb61)
freecad
freeorion
ispike
mirtk
mozart2
performous
pokerth
pokerth-server
python310Packages.foundationdb61
python39Packages.boost169
python39Packages.foundationdb61
starspace
sumokoin
swift-im
twister
vertcoin
vertcoind
xtreemfs
yafaray-core

ghost · 2022-04-13T10:43:09Z

mongodb-4_0: plain log | pretty log

mongodb-4_2: plain log | pretty log

Yeah these also fail at the commit prior to this PR, so I think nixpkgs-review's list of "existing failures" is slightly out of date or something.

SuperSandro2000 · 2022-04-15T02:17:36Z

Yeah these also fail at the commit prior to this PR, so I think nixpkgs-review's list of "existing failures" is slightly out of date or something.

it uses the latest hydra eval which can be a few days behind.

hjones2199

I know its already merged, but just wanted to confirm the three failed builds seem to be from before

ghost requested review from Ericson2314, alyssais, matthewbauer and nbp as code owners February 21, 2022 05:25

github-actions bot added the 6.topic: stdenv Standard environment label Feb 21, 2022

ghost requested review from edolstra and infinisil as code owners February 21, 2022 06:22

ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Feb 21, 2022

This was referenced Feb 26, 2022

mips64: bootstrap-files #161927

Closed

mips64el support #161158

Merged

ghost changed the title ~~mips64: support for cross-compiling boost to a mips64 target~~ boost: support for cross-compiling boost to a mips64 target Mar 3, 2022

ghost changed the title ~~boost: support for cross-compiling boost to a mips64 target~~ boost: support for cross-compiling mips64el Mar 3, 2022

SuperSandro2000 reviewed Mar 4, 2022

View reviewed changes

pkgs/development/libraries/boost/generic.nix Outdated Show resolved Hide resolved

SuperSandro2000 reviewed Mar 4, 2022

View reviewed changes

lib/systems/parse.nix Outdated Show resolved Hide resolved

ghost requested a review from SuperSandro2000 March 4, 2022 19:11

ofborg bot requested a review from hjones2199 March 4, 2022 20:13

ofborg bot requested a review from Ma27 March 4, 2022 21:49

ofborg bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. and removed 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. labels Mar 5, 2022

SuperSandro2000 removed request for NickCao, akshgpt7, evanjs, figsoda, kalbasit and oxalica April 11, 2022 22:23

SuperSandro2000 reviewed Apr 11, 2022

View reviewed changes

pkgs/development/libraries/boost/generic.nix Outdated Show resolved Hide resolved

ofborg bot requested a review from hjones2199 April 12, 2022 03:22

SuperSandro2000 reviewed Apr 12, 2022

View reviewed changes

pkgs/development/libraries/boost/generic.nix Outdated Show resolved Hide resolved

pkgs/development/libraries/boost/generic.nix Outdated Show resolved Hide resolved

ofborg bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Apr 12, 2022

ghost requested a review from SuperSandro2000 April 12, 2022 22:21

boost: support for cross-compiling boost to a mips64 target

1c51548

Co-authored-by: Sandro <sandro.jaeckel@gmail.com>

ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Apr 12, 2022

SuperSandro2000 merged commit 560c144 into NixOS:master Apr 13, 2022

ghost deleted the mips64-boost branch April 13, 2022 10:43

ghost mentioned this pull request Apr 14, 2022

boost: fix taxonomy mistake, account taxonomy change in v1.78 #168573

Merged

7 tasks

hjones2199 reviewed Apr 16, 2022

View reviewed changes

Uh oh!

Conversation

ghost commented Feb 21, 2022 • edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Motivation for this change

Things done

Uh oh!

ghost commented Feb 24, 2022

Uh oh!

ghost commented Mar 3, 2022

Uh oh!

Uh oh!

Uh oh!

ghost commented Mar 4, 2022

Uh oh!

Uh oh!

SuperSandro2000 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

SuperSandro2000 commented Apr 12, 2022

Uh oh!

ghost commented Apr 12, 2022

Uh oh!

ghost commented Apr 12, 2022

Uh oh!

ghost commented Apr 12, 2022

Uh oh!

ghost commented Apr 12, 2022

Uh oh!

ghost commented Apr 13, 2022

Uh oh!

SuperSandro2000 commented Apr 13, 2022

Uh oh!

ghost commented Apr 13, 2022

Uh oh!

SuperSandro2000 commented Apr 15, 2022

Uh oh!

hjones2199 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ghost commented Feb 21, 2022 •

edited by ghost

Loading

hjones2199 left a comment •

edited

Loading